go-packages/iris
1
0
Fork 0
mirror of https://github.com/kataras/iris.git synced 2025-02-02 23:40:35 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

http://support.iris-go.com/d/21-wrong-warning-message-while-redirecting

Browse Source 
Former-commit-id: ca8bebf64f71d84a13f95295863e17dd72fbb9f5
This commit is contained in:
Gerasimos (Makis) Maropoulos 2017-03-09 14:41:08 +02:00
parent d5974f6411
commit 10656e171d
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
context.go
View File

@ -732,9 +732,21 @@ func (ctx *Context) Redirect(urlToRedirect string, statusHeader ...int) {
httpStatus = statusHeader[0] httpStatus = statusHeader[0]
} }
if urlToRedirect == ctx.Path() { // we don't know the Method of the url to redirect,
ctx.Log(DevMode, "trying to redirect to itself. FROM: %s TO: %s", ctx.Path(), urlToRedirect) // sure we can find it by reverse routing as we already implemented
// but it will take too much time for a simple redirect, it doesn't worth it.
// So we are checking the CURRENT Method for GET, HEAD, CONNECT and TRACE.
// the
// Fixes: http: //support.iris-go.com/d/21-wrong-warning-message-while-redirecting
shouldCheckForCycle := urlToRedirect == ctx.Path() && ctx.Method() == MethodGet
// from POST to GET on the same path will give a warning message but developers don't use the iris.DevLogger
// for production, so I assume it's OK to let it logs it
// (it can solve issues when developer redirects to the same handler over and over again)
// Note: it doesn't stops the redirect, the developer gets what he/she expected.
if shouldCheckForCycle {
ctx.Log(DevMode, "warning: redirect from: '%s' to: '%s',\ncurrent method: '%s'", ctx.Path(), urlToRedirect, ctx.Method())
} }
http.Redirect(ctx.ResponseWriter, ctx.Request, urlToRedirect, httpStatus) http.Redirect(ctx.ResponseWriter, ctx.Request, urlToRedirect, httpStatus)
} }