From 585556879435706693d3cb4cca039af3962f0ad8 Mon Sep 17 00:00:00 2001 From: hiveminded Date: Fri, 28 Jul 2017 13:58:02 +0300 Subject: [PATCH] grammar and readme additions :closed_book: Former-commit-id: f63083ed6924b4ed13ea9585501b0c032c1194c1 --- HISTORY.md | 6 ++---- README.md | 3 +++ websocket/server.go | 3 --- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/HISTORY.md b/HISTORY.md index 9781e9d4..cc42612f 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -28,10 +28,8 @@ The API didn't change much except these: - the new implementation does not recognise `Fatal` and `Panic` because, actually, iris never panics - the old `app.Logger().Out = io.Writer` should be written as `app.Logger().SetOutput(io.Writer)` -The new implementation, [golog](https://github.com/kataras/golog) is more featured -and it completes more use cases than the before external implementation. - -At general you have to know that the low-level relative fields and functions are actually inside `app.Logger().Printer` object, i.e: `app.Logger().Printer.Output` to get the `io.Writer` or `app.Logger().Printer.AddOuput/SetOutput` to set or add more output(`io.Writer`) targets. +The new implementation, [golog](https://github.com/kataras/golog) is featured, **[three times faster than logrus](https://github.com/kataras/golog/tree/master/_benchmarks)** +and it completes every common usage. ### Integration diff --git a/README.md b/README.md index bc9d5510..7dc8b40e 100644 --- a/README.md +++ b/README.md @@ -2,9 +2,12 @@ Iris is a fast, simple and efficient micro web framework for Go. It provides a beautifully expressive and easy to use foundation for your next website, API, or distributed app. +[![total used by](http://iris-go.com/graph?style=flat-square)](http://iris-go.com/graph) [![build status](https://img.shields.io/travis/kataras/iris/master.svg?style=flat-square)](https://travis-ci.org/kataras/iris) [![report card](https://img.shields.io/badge/report%20card-a%2B-ff3333.svg?style=flat-square)](http://goreportcard.com/report/kataras/iris) [![godocs](https://img.shields.io/badge/godocs-8.x.x-0366d6.svg?style=flat-square)](https://godoc.org/github.com/kataras/iris) +[![github closed issues](https://img.shields.io/github/issues-closed-raw/kataras/iris.svg?style=flat-square)](https://github.com/kataras/iris/issues?q=is%3Aissue+is%3Aclosed) +[![issue stats](https://img.shields.io/issuestats/i/github/kataras/iris.svg?style=flat-square)](https://github.com/kataras/iris/issues?q=is%3Aissue+is%3Aclosed) [![get support](https://img.shields.io/badge/get-support-cccc00.svg?style=flat-square)](http://support.iris-go.com) [![view examples](https://img.shields.io/badge/learn%20by-examples-0077b3.svg?style=flat-square)](https://github.com/kataras/iris/tree/master/_examples) [![chat](https://img.shields.io/badge/community-%20chat-00BCD4.svg?style=flat-square)](https://kataras.rocket.chat/channel/iris) diff --git a/websocket/server.go b/websocket/server.go index 07abc08a..50f54c16 100644 --- a/websocket/server.go +++ b/websocket/server.go @@ -222,9 +222,6 @@ func (s *Server) handleConnection(ctx context.Context, websocketConn UnderlineCo // OnConnection is the main event you, as developer, will work with each of the websocket connections. func (s *Server) OnConnection(cb ConnectionFunc) { - if s.handler == nil { - - } s.onConnectionListeners = append(s.onConnectionListeners, cb) }