go-packages/iris
1
0
Fork 0
mirror of https://github.com/kataras/iris.git synced 2025-03-15 08:06:27 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

controller's struct: if unexported field(s) is set-ed manually (binder cannot do that) and no other dynamic dependency(depends on context) then tag the controller as singleton, use a single controller instance to serve all clients (the controller's methods are per-request of course but its(controller's) fields will be 'global'- users should be careful because parallel access of those fields are up to them by using mutex or atomic or values that are safe for concurrent access.

Browse Source 
Former-commit-id: dfafcb3a37a9b33d713bf47f16dd60764b026a08
This commit is contained in:
Gerasimos (Makis) Maropoulos 2017-12-20 00:01:50 +02:00
parent c15763c556
commit 6285622cfa
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
mvc/di/struct.go
View File

@ -83,13 +83,14 @@ func MakeStructInjector(v reflect.Value, hijack Hijacker, goodFunc TypeChecker,
s.HasFields = len(s.fields) > 0 s.HasFields = len(s.fields) > 0
// set the overall state of this injector. // set the overall state of this injector.
s.setState()
s.fillStruct() s.fillStruct()
s.setState()
return s return s
} }
// set the state, once. // set the state, once.
// Here the "initRef" have already the static bindings and the manually-filled fields.
func (s *StructInjector) setState() { func (s *StructInjector) setState() {
// note for zero length of struct's fields: // note for zero length of struct's fields:
// if struct doesn't contain any field // if struct doesn't contain any field
@ -102,21 +103,31 @@ func (s *StructInjector) setState() {
// added the `.State` now. // added the `.State` now.
staticBindingsFieldsLength := s.countBindType(Static) staticBindingsFieldsLength := s.countBindType(Static)
structFieldsLength := NumFields(s.elemType, false) allStructFieldsLength := NumFields(s.elemType, false)
// check if unexported(and exported) fields are set-ed manually or via binding (at this time we have all fields set-ed inside the "initRef")
// i.e &Controller{unexportedField: "my value"}
// or dependencies values = "my value" and Controller struct {Field string}
// if so then set the temp staticBindingsFieldsLength to that number, so for example:
// if static binding length is 0
// but an unexported field is set-ed then act that as singleton.
if allStructFieldsLength > staticBindingsFieldsLength {
structFieldsUnexportedNonZero := LookupNonZeroFieldsValues(s.initRef, false)
staticBindingsFieldsLength = len(structFieldsUnexportedNonZero)
}
// println("staticBindingsFieldsLength: ", staticBindingsFieldsLength) // println("staticBindingsFieldsLength: ", staticBindingsFieldsLength)
// println("structFieldsLength: ", structFieldsLength) // println("allStructFieldsLength: ", allStructFieldsLength)
// if the number of static values binded is equal to the // if the number of static values binded is equal to the
// total struct's fields(including unexported fields this time) then set as singleton. // total struct's fields(including unexported fields this time) then set as singleton.
if staticBindingsFieldsLength == structFieldsLength { if staticBindingsFieldsLength == allStructFieldsLength {
s.State = Singleton s.State = Singleton
// the default is `Stateless`, which means that a new instance should be created
// on each inject action by the caller.
return return
} }
s.CanInject = s.State == Stateless && s.HasFields s.CanInject = s.State == Stateless && s.HasFields
// the default is `Stateless`, which means that a new instance should be created
// on each inject action by the caller.
} }
// fill the static bindings values once. // fill the static bindings values once.