diff --git a/_benchmarks/README.md b/_benchmarks/README.md index b528d3ae..65f40b80 100644 --- a/_benchmarks/README.md +++ b/_benchmarks/README.md @@ -227,7 +227,7 @@ Bombarding http://localhost:5000/api/values/5 with 1000000 requests using 125 co 1000000 / 1000000 [=======================================================================================] 100.00% 1m25s Done! Statistics Avg Stdev Max - Reqs/sec 11665.30 628.41 21978 + Reqs/sec 11665.30 628.41 21978 Latency 10.72ms 1.45ms 112.10ms HTTP codes: 1xx - 0, 2xx - 1000000, 3xx - 0, 4xx - 0, 5xx - 0 diff --git a/sessions/sessiondb/redis/database.go b/sessions/sessiondb/redis/database.go index ccfbe968..2d827b5b 100644 --- a/sessions/sessiondb/redis/database.go +++ b/sessions/sessiondb/redis/database.go @@ -49,22 +49,20 @@ func (db *Database) Load(sid string) (storeDB sessions.RemoteStore) { // fetch the values from this session id and copy-> store them storeMaybe, err := db.redis.Get(sid) - if err != nil { - golog.Errorf("error while trying to load session values(%s) from redis: %v", sid, err) - return - } + // exists + if err == nil { + storeB, ok := storeMaybe.([]byte) + if !ok { + golog.Errorf("something wrong, store should be stored as []byte but stored as %#v", storeMaybe) + return + } - storeB, ok := storeMaybe.([]byte) - if !ok { - golog.Errorf("something wrong, store should be stored as []byte but stored as %#v", storeMaybe) - return - } - - storeDB, err = sessions.DecodeRemoteStore(storeB) // decode the whole value, as a remote store - if err != nil { - golog.Errorf(`error while trying to load session values(%s) from redis: - the retrieved value is not a sessions.RemoteStore type, please report that as bug, that should never occur`, - sid) + storeDB, err = sessions.DecodeRemoteStore(storeB) // decode the whole value, as a remote store + if err != nil { + golog.Errorf(`error while trying to load session values(%s) from redis: + the retrieved value is not a sessions.RemoteStore type, please report that as bug, that should never occur: %v`, + sid, err) + } } return