go-packages/iris
1
0
Fork 0
mirror of https://github.com/kataras/iris.git synced 2025-03-15 05:26:26 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix CookieNeverExpires time, set an option for -1 for browser-based session (when browser closes cookie is removed)

Browse Source
This commit is contained in:
Gerasimos Maropoulos 2016-07-26 21:26:54 +03:00
parent c26ce245c7
commit 8288161b30
3 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
config/sessions.go
View File

@ -8,8 +8,8 @@ import (
var ( var (
universe time.Time // 0001-01-01 00:00:00 +0000 UTC universe time.Time // 0001-01-01 00:00:00 +0000 UTC
// CookieExpireNever the default cookie's life for sessions, unlimited // CookieExpireNever the default cookie's life for sessions, unlimited (23 years)
CookieExpireNever = universe CookieExpireNever = time.Now().AddDate(23, 0, 0)
) )
const ( const (
@ -35,7 +35,10 @@ type (
// Defaults to false // Defaults to false
DecodeCookie bool DecodeCookie bool
// Expires the duration of which the cookie must expires (created_time.Add(Expires)). // Expires the duration of which the cookie must expires (created_time.Add(Expires)).
// If you want to delete the cookie when the browser closes, set it to -1 but in this case, the server side's session duration is up to GcDuration
//
// Default infinitive/unlimited life duration(0) // Default infinitive/unlimited life duration(0)
Expires time.Duration Expires time.Duration
// GcDuration every how much duration(GcDuration) the memory should be clear for unused cookies (GcDuration) // GcDuration every how much duration(GcDuration) the memory should be clear for unused cookies (GcDuration)
// for example: time.Duration(2)*time.Hour. it will check every 2 hours if cookie hasn't be used for 2 hours, // for example: time.Duration(2)*time.Hour. it will check every 2 hours if cookie hasn't be used for 2 hours,

7
http.go
View File

@ -343,14 +343,15 @@ func (s *Server) FullHost() string {
// Hostname returns the hostname part of the host (host expect port) // Hostname returns the hostname part of the host (host expect port)
func (s *Server) Hostname() string { func (s *Server) Hostname() string {
idxPort := strings.IndexByte(s.Host(), ':') a := s.Host()
idxPort := strings.IndexByte(a, ':')
if idxPort > 0 { if idxPort > 0 {
// port exists, (it always exists for Config.ListeningAddr // port exists, (it always exists for Config.ListeningAddr
return s.Host()[0:idxPort] // except the port return a[0:idxPort] // except the port
} // but for Config.VListeningAddr the developer maybe doesn't uses the host:port format } // but for Config.VListeningAddr the developer maybe doesn't uses the host:port format
// so, if no port found, then return the Host as it is, it should be something 'mydomain.com' // so, if no port found, then return the Host as it is, it should be something 'mydomain.com'
return s.Host() return a
} }
func (s *Server) listen() error { func (s *Server) listen() error {

6
sessions.go
View File

@ -154,7 +154,7 @@ func (p *sessionProvider) newSession(sid string) *session {
lastAccessedTime: time.Now(), lastAccessedTime: time.Now(),
values: p.loadSessionValues(sid), values: p.loadSessionValues(sid),
} }
if p.expires > 0 { // if not unlimited life duration if p.expires > 0 { // if not unlimited life duration and no -1 (cookie remove action is based on browser's session)
time.AfterFunc(p.expires, func() { time.AfterFunc(p.expires, func() {
// the destroy makes the check if this session is exists then or not, // the destroy makes the check if this session is exists then or not,
// this is used to destroy the session from the server-side also // this is used to destroy the session from the server-side also
@ -348,9 +348,9 @@ func (m *sessionsManager) start(ctx *Context) *session {
if m.config.Expires == 0 { if m.config.Expires == 0 {
// unlimited life // unlimited life
cookie.SetExpire(config.CookieExpireNever) cookie.SetExpire(config.CookieExpireNever)
} else { } else if m.config.Expires > 0 {
cookie.SetExpire(time.Now().Add(m.config.Expires)) cookie.SetExpire(time.Now().Add(m.config.Expires))
} } // if it's -1 then the cookie is deleted when the browser closes
ctx.SetCookie(cookie) ctx.SetCookie(cookie)
fasthttp.ReleaseCookie(cookie) fasthttp.ReleaseCookie(cookie)