go-packages/iris
1
0
Fork 0
mirror of https://github.com/kataras/iris.git synced 2025-03-14 08:16:28 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

sessions database: boltdb: add support for ShiftExpiration -> OnUpdateExpiration like redis

Browse Source 
badger sessiondb still in progress.


Former-commit-id: 1f89a0efb753c0e02b774e0d9e48d879e987c939
This commit is contained in:
Gerasimos (Makis) Maropoulos 2018-08-18 15:01:26 +03:00
parent 197fb5d113
commit b4a30f5af5
2 changed files with 29 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sessions/database.go
View File

@ -32,8 +32,7 @@ type Database interface {
// //
// Check of error is required, if error returned then the rest session's keys are not proceed. // Check of error is required, if error returned then the rest session's keys are not proceed.
// //
// Currently only "redis" database is designed to use that event. // If a database does not support this feature then an `ErrNotImplemented` will be returned instead.
// If A database is not support this feature then a `ErrNotImplemented` will be returned instead.
OnUpdateExpiration(sid string, newExpires time.Duration) error OnUpdateExpiration(sid string, newExpires time.Duration) error
// Set sets a key value of a specific session. // Set sets a key value of a specific session.
// The "immutable" input argument depends on the store, it may not implement it at all. // The "immutable" input argument depends on the store, it may not implement it at all.

36
sessions/sessiondb/boltdb/database.go
View File

@ -210,10 +210,31 @@ func (db *Database) Acquire(sid string, expires time.Duration) (lifetime session
return return
} }
// OnUpdateExpiration not implemented here, yet. // OnUpdateExpiration will re-set the database's session's entry ttl.
// Note that this error will not be logged, callers should catch it manually.
func (db *Database) OnUpdateExpiration(sid string, newExpires time.Duration) error { func (db *Database) OnUpdateExpiration(sid string, newExpires time.Duration) error {
return sessions.ErrNotImplemented expirationTime := time.Now().Add(newExpires)
timeBytes, err := sessions.DefaultTranscoder.Marshal(expirationTime)
if err != nil {
return err
}
err = db.Service.Update(func(tx *bolt.Tx) error {
expirationName := getExpirationBucketName([]byte(sid))
root := db.getBucket(tx)
b := root.Bucket(expirationName)
if b == nil {
// golog.Debugf("tried to reset the expiration value for '%s' while its configured lifetime is unlimited or the session is already expired and not found now", sid)
return sessions.ErrNotFound
}
return b.Put(expirationKey, timeBytes)
})
if err != nil {
golog.Debugf("unable to reset the expiration value for '%s': %v", sid, err)
}
return err
} }
func makeKey(key string) []byte { func makeKey(key string) []byte {
@ -306,14 +327,12 @@ func (db *Database) Len(sid string) (n int) {
return return
} }
var errNotFound = errors.New("not found")
// Delete removes a session key value based on its key. // Delete removes a session key value based on its key.
func (db *Database) Delete(sid string, key string) (deleted bool) { func (db *Database) Delete(sid string, key string) (deleted bool) {
err := db.Service.Update(func(tx *bolt.Tx) error { err := db.Service.Update(func(tx *bolt.Tx) error {
b := db.getBucketForSession(tx, sid) b := db.getBucketForSession(tx, sid)
if b == nil { if b == nil {
return errNotFound return sessions.ErrNotFound
} }
return b.Delete(makeKey(key)) return b.Delete(makeKey(key))
@ -343,12 +362,13 @@ func (db *Database) Release(sid string) {
// delete the session bucket. // delete the session bucket.
b := db.getBucket(tx) b := db.getBucket(tx)
bsid := []byte(sid) bsid := []byte(sid)
// try to delete the associated expiration bucket, if exists, ignore error.
b.DeleteBucket(getExpirationBucketName(bsid))
if err := b.DeleteBucket(bsid); err != nil { if err := b.DeleteBucket(bsid); err != nil {
return err return err
} }
// and try to delete the associated expiration bucket, if exists, ignore error.
b.DeleteBucket(getExpirationBucketName(bsid))
return nil return nil
}) })
} }