replace all common error responses with the new Context.StopWithError

Former-commit-id: 99b08a0b5564ef640456db12674cb37721f73ae3

_examples/experimental-handlers/cors/simple/main.go

@@ -16,6 +16,7 @@ func main() {
 			ctx.StatusCode(iris.StatusNoContent)
 			return
 		}
+
 		ctx.Next()
 	} // or	"github.com/iris-contrib/middleware/cors"
 
@@ -25,8 +26,7 @@ func main() {
 			var any iris.Map
 			err := ctx.ReadJSON(&any)
 			if err != nil {
-				ctx.WriteString(err.Error())
+				ctx.StopWithError(iris.StatusBadRequest, err)
-				ctx.StatusCode(iris.StatusBadRequest)
 				return
 			}
 			ctx.Application().Logger().Infof("received %#+v", any)

_examples/http_request/read-custom-per-type/main.go

@@ -56,8 +56,7 @@ func handler(ctx iris.Context) {
 	//
 
 	if err := ctx.UnmarshalBody(&c, nil); err != nil {
-		ctx.StatusCode(iris.StatusBadRequest)
+		ctx.StopWithError(iris.StatusBadRequest, err)
-		ctx.WriteString(err.Error())
 		return
 	}
 

_examples/http_request/read-custom-via-unmarshaler/main.go

@@ -64,8 +64,7 @@ func handler(ctx iris.Context) {
 	//
 
 	if err := ctx.UnmarshalBody(&c, iris.UnmarshalerFunc(yaml.Unmarshal)); err != nil {
-		ctx.StatusCode(iris.StatusBadRequest)
+		ctx.StopWithError(iris.StatusBadRequest, err)
-		ctx.WriteString(err.Error())
 		return
 	}
 

_examples/http_request/read-form/main.go

@@ -19,8 +19,8 @@ func main() {
 
 	app.Get("/", func(ctx iris.Context) {
 		if err := ctx.View("form.html"); err != nil {
-			ctx.StatusCode(iris.StatusInternalServerError)
+			ctx.StopWithError(iris.StatusInternalServerError, err)
-			ctx.WriteString(err.Error())
+			return
 		}
 	})
 
@@ -28,8 +28,8 @@ func main() {
 		visitor := Visitor{}
 		err := ctx.ReadForm(&visitor)
 		if err != nil && !iris.IsErrPath(err) /* see: https://github.com/kataras/iris/issues/1157 */ {
-			ctx.StatusCode(iris.StatusInternalServerError)
+			ctx.StopWithError(iris.StatusInternalServerError, err)
-			ctx.WriteString(err.Error())
+			return
 		}
 
 		ctx.Writef("Visitor: %#v", visitor)

_examples/http_request/read-json/main.go

@@ -14,8 +14,7 @@ func MyHandler(ctx iris.Context) {
 	var c Company
 
 	if err := ctx.ReadJSON(&c); err != nil {
-		ctx.StatusCode(iris.StatusBadRequest)
+		ctx.StopWithError(iris.StatusBadRequest, err)
-		ctx.WriteString(err.Error())
 		return
 	}
 
@@ -33,8 +32,7 @@ func MyHandler2(ctx iris.Context) {
 	var persons []Person
 	err := ctx.ReadJSON(&persons)
 	if err != nil {
-		ctx.StatusCode(iris.StatusBadRequest)
+		ctx.StopWithError(iris.StatusBadRequest, err)
-		ctx.WriteString(err.Error())
 		return
 	}
 

_examples/http_request/read-many/main.go

@@ -11,8 +11,7 @@ func main() {
 		// body, err := ioutil.ReadAll(ctx.Request().Body) once or
 		body, err := ctx.GetBody() // as many times as you need.
 		if err != nil {
-			ctx.StatusCode(iris.StatusInternalServerError)
+			ctx.StopWithError(iris.StatusInternalServerError, err)
-			ctx.WriteString(err.Error())
 			return
 		}
 

_examples/http_request/read-msgpack/main.go

@@ -15,8 +15,7 @@ func readMsgPack(ctx iris.Context) {
 	var u User
 	err := ctx.ReadMsgPack(&u)
 	if err != nil {
-		ctx.StatusCode(iris.StatusBadRequest)
+		ctx.StopWithError(iris.StatusBadRequest, err)
-		ctx.WriteString(err.Error())
 		return
 	}
 

_examples/http_request/read-query/main.go

@@ -17,8 +17,8 @@ func main() {
 		var t MyType
 		err := ctx.ReadQuery(&t)
 		if err != nil && !iris.IsErrPath(err) {
-			ctx.StatusCode(iris.StatusInternalServerError)
+			ctx.StopWithError(iris.StatusInternalServerError, err)
-			ctx.WriteString(err.Error())
+			return
 		}
 
 		ctx.Writef("MyType: %#v", t)

_examples/http_request/read-xml/main.go

@@ -41,8 +41,7 @@ type person struct {
 func handler(ctx iris.Context) {
 	var p person
 	if err := ctx.ReadXML(&p); err != nil {
-		ctx.StatusCode(iris.StatusBadRequest)
+		ctx.StopWithError(iris.StatusBadRequest, err)
-		ctx.WriteString(err.Error())
 		return
 	}
 

_examples/http_request/read-yaml/main.go

@@ -22,8 +22,7 @@ type product struct {
 func handler(ctx iris.Context) {
 	var p product
 	if err := ctx.ReadYAML(&p); err != nil {
-		ctx.StatusCode(iris.StatusBadRequest)
+		ctx.StopWithError(iris.StatusBadRequest, err)
-		ctx.WriteString(err.Error())
 		return
 	}
 

_examples/http_request/upload-files/main.go

@@ -52,8 +52,7 @@ func main() {
 
 		err := ctx.Request().ParseMultipartForm(maxSize)
 		if err != nil {
-			ctx.StatusCode(iris.StatusInternalServerError)
+			ctx.StopWithError(iris.StatusInternalServerError, err)
-			ctx.WriteString(err.Error())
 			return
 		}
 

_examples/http_responsewriter/herotemplate/app.go

@@ -45,8 +45,8 @@ func main() {
 
 		_, err := ctx.Write(buffer.Bytes())
 		if err != nil {
-			ctx.StatusCode(iris.StatusInternalServerError)
+			ctx.StopWithError(iris.StatusInternalServerError, err)
-			ctx.WriteString(err.Error())
+			return
 		}
 	})
 

context/context.go

@@ -1576,8 +1576,8 @@ func (ctx *context) StopWithStatus(statusCode int) {
 // If the status code is a failure one then
 // it will also fire the specified error code handler.
 func (ctx *context) StopWithText(statusCode int, plainText string) {
-	ctx.WriteString(plainText)
 	ctx.StopWithStatus(statusCode)
+	ctx.WriteString(plainText)
 }
 
 // StopWithError stops the handlers chain and writes the "statusCode"

hero/struct_test.go

@@ -56,9 +56,7 @@ func TestStruct(t *testing.T) {
 type testStructErrorHandler struct{}
 
 func (s *testStructErrorHandler) HandleError(ctx iris.Context, err error) {
-	ctx.StatusCode(httptest.StatusConflict)
+	ctx.StopWithError(httptest.StatusConflict, err)
-	ctx.WriteString(err.Error())
-	ctx.StopExecution()
 }
 
 func (s *testStructErrorHandler) Handle(errText string) error {