go-packages/paypal
1
0
Fork 1
mirror of https://github.com/plutov/paypal.git synced 2025-01-23 10:21:03 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix json parsing of the details field in API error responses with a new ErrorResponseDetail type.

Browse Source 
The `details` field in the json response from API errors is an array of json objects (not a single object).
Also, the value for the "link" object is not a string but rather another nested array of json objects.
The parsing of the `details` json field is now correctly unmarshalled into a new `ErrorResponseDetail` type
instead of the previously broken `map[string]string` type.
This commit is contained in:
Sam Choukri 2017-10-25 17:43:41 -07:00
parent 08326c3caa
commit 3beae33bc0
2 changed files with 80 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
types.go
View File

@ -222,14 +222,20 @@ type (
GiftWrap string `json:"gift_wrap,omitempty"`
}
ErrorResponseDetail struct {
Field string `json:"field"`
Issue string `json:"issue"`
Links []Link `json:"link"`
}
// ErrorResponse https://developer.paypal.com/docs/api/errors/
ErrorResponse struct {
Response *http.Response `json:"-"`
Name string `json:"name"`
DebugID string `json:"debug_id"`
Message string `json:"message"`
InformationLink string `json:"information_link"`
Details map[string]string `json:"details"`
Response *http.Response `json:"-"`
Name string `json:"name"`
DebugID string `json:"debug_id"`
Message string `json:"message"`
InformationLink string `json:"information_link"`
Details []ErrorResponseDetail `json:"details"`
}
// ExecuteAgreementResponse struct

68
unit_test.go
View File

@ -76,6 +76,74 @@ func TestTypeItem(t *testing.T) {
}
}
func TestTypeErrorResponseOne(t *testing.T) {
response := `{
"name":"USER_BUSINESS_ERROR",
"message":"User business error.",
"debug_id":"f05063556a338",
"information_link":"https://developer.paypal.com/docs/api/payments.payouts-batch/#errors",
"details":[
{
"field":"SENDER_BATCH_ID",
"issue":"Batch with given sender_batch_id already exists",
"link":[
{
"href":"https://api.sandbox.paypal.com/v1/payments/payouts/CR9VS2K4X4846",
"rel":"self",
"method":"GET"
}
]
}
]
}`
i := &ErrorResponse{}
err := json.Unmarshal([]byte(response), i)
if err != nil {
t.Errorf("ErrorResponse Unmarshal failed")
}
if i.Name != "USER_BUSINESS_ERROR" ||
i.Message != "User business error." ||
i.DebugID != "f05063556a338" ||
i.InformationLink != "https://developer.paypal.com/docs/api/payments.payouts-batch/#errors" ||
len(i.Details) != 1 ||
i.Details[0].Field != "SENDER_BATCH_ID" ||
i.Details[0].Issue != "Batch with given sender_batch_id already exists" ||
len(i.Details[0].Links) != 1 ||
i.Details[0].Links[0].Href != "https://api.sandbox.paypal.com/v1/payments/payouts/CR9VS2K4X4846" {
t.Errorf("ErrorResponse decoded result is incorrect, Given: %v", i)
}
}
func TestTypeErrorResponseTwo(t *testing.T) {
response := `{
"name":"VALIDATION_ERROR",
"message":"Invalid request - see details.",
"debug_id":"662121ee369c0",
"information_link":"https://developer.paypal.com/docs/api/payments.payouts-batch/#errors",
"details":[
{
"field":"items[0].recipient_type",
"issue":"Value is invalid (must be EMAILor PAYPAL_ID or PHONE)"
}
]
}`
i := &ErrorResponse{}
err := json.Unmarshal([]byte(response), i)
if err != nil {
t.Errorf("ErrorResponse Unmarshal failed")
}
if i.Name != "VALIDATION_ERROR" ||
i.Message != "Invalid request - see details." ||
len(i.Details) != 1 ||
i.Details[0].Field != "items[0].recipient_type" {
t.Errorf("ErrorResponse decoded result is incorrect, Given: %v", i)
}
}
// ServeHTTP implements http.Handler
func (ts *webprofileTestServer) ServeHTTP(w http.ResponseWriter, r *http.Request) {
ts.t.Log(r.RequestURI)